mjsax commented on code in PR #18867:
URL: https://github.com/apache/kafka/pull/18867#discussion_r1952162123
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StaticTopicNameExtractor.java:
##########
@@ -28,8 +28,9 @@ public class StaticTopicNameExtractor<K, V> implements
TopicNameExtractor<K, V>
public final String topicName;
- public StaticTopicNameExtractor(final String topicName) {
- this.topicName = topicName;
+ public StaticTopicNameExtractor(final String topic) {
+ Objects.requireNonNull(topic, "topic cannot be null");
Review Comment:
Unifying null check in there to avoid this check in multiple places when
used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
