apoorvmittal10 commented on code in PR #18862:
URL: https://github.com/apache/kafka/pull/18862#discussion_r1952488284
##########
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##########
@@ -323,28 +340,28 @@ public void testNewContext() {
assertEquals(respData2, resp2.responseData(topicNames));
ShareSessionKey shareSessionKey2 = new ShareSessionKey(groupId,
- reqMetadata2.memberId());
+ reqMetadata2.memberId());
// Test trying to create a new session with an invalid epoch
assertThrows(InvalidShareSessionEpochException.class, () ->
sharePartitionManager.newContext(groupId, reqData2, EMPTY_PART_LIST,
- new ShareRequestMetadata(shareSessionKey2.memberId(), 5),
true));
+ new ShareRequestMetadata(shareSessionKey2.memberId(), 5), true));
// Test trying to create a new session with a non-existent session key
Uuid memberId4 = Uuid.randomUuid();
assertThrows(ShareSessionNotFoundException.class, () ->
sharePartitionManager.newContext(groupId, reqData2, EMPTY_PART_LIST,
- new ShareRequestMetadata(memberId4, 1), true));
+ new ShareRequestMetadata(memberId4, 1), true));
// Continue the first share session we created.
ShareFetchContext context5 = sharePartitionManager.newContext(groupId,
Collections.emptyMap(), EMPTY_PART_LIST,
- new ShareRequestMetadata(shareSessionKey2.memberId(), 1),
true);
+ new ShareRequestMetadata(shareSessionKey2.memberId(), 1), true);
assertEquals(ShareSessionContext.class, context5.getClass());
assertTrue(((ShareSessionContext) context5).isSubsequent());
ShareSessionContext shareSessionContext5 = (ShareSessionContext)
context5;
synchronized (shareSessionContext5.session()) {
shareSessionContext5.session().partitionMap().forEach(cachedSharePartition -> {
TopicIdPartition topicIdPartition = new
TopicIdPartition(cachedSharePartition.topicId(), new
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
