apoorvmittal10 commented on code in PR #18862:
URL: https://github.com/apache/kafka/pull/18862#discussion_r1952540637


##########
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##########
@@ -180,16 +181,23 @@ public void setUp() {
 
     @AfterEach
     public void tearDown() throws Exception {
-        mockTimer.close();
+        if (sharePartitionManager != null) {
+            sharePartitionManager.close();
+        } else {
+            mockTimer.close();

Review Comment:
   I have corrected other tests and validated the mockTimer is closed as part 
of share partition manager. There shouldn't be pending thread of system timer 
reaper. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to