ijuma commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1952687484
##########
metadata/src/test/java/org/apache/kafka/controller/FeatureControlManagerTest.java:
##########
@@ -240,38 +241,29 @@ public void testReplayRecords() {
private static final FeatureControlManager.Builder TEST_MANAGER_BUILDER1 =
new FeatureControlManager.Builder().
setQuorumFeatures(features(MetadataVersion.FEATURE_NAME,
- MetadataVersion.IBP_3_3_IV0.featureLevel(),
MetadataVersion.IBP_3_3_IV3.featureLevel())).
- setMetadataVersion(MetadataVersion.IBP_3_3_IV2);
+ MetadataVersion.MINIMUM_VERSION.featureLevel(),
MetadataVersion.IBP_3_6_IV0.featureLevel())).
+ setMetadataVersion(MetadataVersion.IBP_3_4_IV0);
@Test
public void testApplyMetadataVersionChangeRecord() {
FeatureControlManager manager = TEST_MANAGER_BUILDER1.build();
manager.replay(new FeatureLevelRecord().
setName(MetadataVersion.FEATURE_NAME).
- setFeatureLevel(MetadataVersion.IBP_3_3_IV3.featureLevel()));
- assertEquals(MetadataVersion.IBP_3_3_IV3, manager.metadataVersion());
- }
-
- @Test
- public void
testCannotDowngradeToVersionBeforeMinimumSupportedKraftVersion() {
- FeatureControlManager manager = TEST_MANAGER_BUILDER1.build();
- assertEquals(ControllerResult.of(Collections.emptyList(), new
ApiError(Errors.INVALID_UPDATE_VERSION,
- "Invalid update version 3 for feature metadata.version. Local
controller 0 only " +
- "supports versions 4-7")),
- manager.updateFeatures(
- singletonMap(MetadataVersion.FEATURE_NAME,
MetadataVersion.IBP_3_2_IV0.featureLevel()),
- singletonMap(MetadataVersion.FEATURE_NAME,
FeatureUpdate.UpgradeType.UNSAFE_DOWNGRADE),
- true));
+ setFeatureLevel(MetadataVersion.IBP_3_4_IV0.featureLevel()));
Review Comment:
This was previously checking that the metadata version would change and
using minimum would take it backwards. But I did notice an issue where we are
actually using the same version versus a newer one - fixing that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
