ijuma commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1952741967
##########
metadata/src/test/java/org/apache/kafka/image/FeaturesImageTest.java:
##########
@@ -163,7 +163,7 @@ public void testEmpty() {
assertFalse(new FeaturesImage(Collections.singletonMap("foo", (short)
1),
FeaturesImage.EMPTY.metadataVersion()).isEmpty());
assertFalse(new FeaturesImage(FeaturesImage.EMPTY.finalizedVersions(),
- MetadataVersion.IBP_3_3_IV0).isEmpty());
+ MetadataVersion.IBP_3_4_IV0).isEmpty());
Review Comment:
That causes the test to fail. This is related to your question of whether
`FeatuesImage.isEmpty` should be changed not to include
`metadataVersion.equals(MetadataVersion.MINIMUM_VERSION)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
