lianetm commented on code in PR #18737:
URL: https://github.com/apache/kafka/pull/18737#discussion_r1957172461
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java:
##########
@@ -837,6 +849,9 @@ void maybeReconcile() {
revokedPartitions.addAll(ownedPartitions);
revokedPartitions.removeAll(assignedTopicPartitions);
+ if (autoCommitEnabled && !revokedPartitions.isEmpty() && !canCommit)
return;
+ markReconciliationInProgress();
Review Comment:
yes, good point, agree. Actually, that was the intention initially, we were
aborting the reconciliation attempt if auto-commit enabled and canCommit=false,
nothing else. I myself got mixed up trying to not delay the reconciliation if
there were no revocations, but we truly can't. We need to commit before
rebalances.
Btw, this same mix up is in the name of the func in
`signalReconciliationStart`. It calls `maybeAutoCommitSyncBeforeRevocation`,
when it really should be named `maybeAutoCommitSyncBeforeRebalance`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
