junrao commented on code in PR #18737:
URL: https://github.com/apache/kafka/pull/18737#discussion_r1962213079
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java:
##########
@@ -123,8 +123,7 @@ public class ConsumerMembershipManager extends
AbstractMembershipManager<Consume
private final Optional<String> serverAssignor;
/**
- * Manager to perform commit requests needed before revoking partitions
(if auto-commit is
- * enabled)
+ * Manager to perform commit requests needed before rebalance (if
auto-commit is enabled)
Review Comment:
This makes it sound like that commitRequestManager is only used for auto
offset commit, but it's used for commit calls from the users too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
