frankvicky commented on code in PR #18969:
URL: https://github.com/apache/kafka/pull/18969#discussion_r1962907658
##########
core/src/main/scala/kafka/utils/LoggingController.scala:
##########
@@ -112,24 +112,30 @@ private class Log4jCoreController extends
LoggingControllerDelegate {
val level = Level.toLevel(logLevel.toUpperCase(Locale.ROOT))
if (loggerName == ROOT_LOGGER) {
- Configurator.setAllLevels(LogManager.ROOT_LOGGER_NAME, level)
+ Configurator.setLevel(LogManager.ROOT_LOGGER_NAME, level)
true
} else {
if (loggerExists(loggerName) && level != null) {
- Configurator.setAllLevels(loggerName, level)
+ Configurator.setLevel(loggerName, level)
true
}
else false
}
}
override def unsetLogLevel(loggerName: String): Boolean = {
+ val nullLevel: String = null
if (loggerName == ROOT_LOGGER) {
- Configurator.setAllLevels(LogManager.ROOT_LOGGER_NAME, null)
+ Configurator.setLevel(LogManager.ROOT_LOGGER_NAME, nullLevel)
true
} else {
if (loggerExists(loggerName)) {
- Configurator.setAllLevels(loggerName, null)
+ val parent = logContext.getLogger(loggerName).getParent
+ if (parent == null) {
+ Configurator.setLevel(loggerName, nullLevel)
+ } else {
+ Configurator.setLevel(loggerName, parent.getLevel)
+ }
Review Comment:
I try to align with the behavior of the old version of Kafka here.
https://github.com/apache/kafka/blob/66e2ac0e098f6ee83deaf5501bf3f606d29b35fa/core/src/main/scala/kafka/utils/Log4jController.scala#L33-L49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
