chia7712 commented on code in PR #18969:
URL: https://github.com/apache/kafka/pull/18969#discussion_r1963548344
##########
core/src/main/scala/kafka/utils/LoggingController.scala:
##########
@@ -112,24 +112,30 @@ private class Log4jCoreController extends
LoggingControllerDelegate {
val level = Level.toLevel(logLevel.toUpperCase(Locale.ROOT))
if (loggerName == ROOT_LOGGER) {
- Configurator.setAllLevels(LogManager.ROOT_LOGGER_NAME, level)
+ Configurator.setLevel(LogManager.ROOT_LOGGER_NAME, level)
true
} else {
if (loggerExists(loggerName) && level != null) {
- Configurator.setAllLevels(loggerName, level)
+ Configurator.setLevel(loggerName, level)
true
}
else false
}
}
override def unsetLogLevel(loggerName: String): Boolean = {
+ val nullLevel: String = null
Review Comment:
we can't use null string, as it is converted to DEBUG level by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
