jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1964115601
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -5177,9 +5177,12 @@ class ReplicaManagerTest {
replicaManager.getPartition(topicPartition) match {
case HostedPartition.Online(partition) =>
partition.appendRecordsToFollowerOrFutureReplica(
- records = MemoryRecords.withRecords(Compression.NONE, 0,
- new SimpleRecord("first message".getBytes)),
- isFuture = false
+ records = MemoryRecords.withRecords(
+ Compression.NONE, 0,
+ new SimpleRecord("first message".getBytes)
+ ),
+ isFuture = false,
+ partitionLeaderEpoch = Int.MaxValue
Review Comment:
Sure. Fixed it. I wanted to make it explicit that this test was "ignoring"
the skip higher leader epoch logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
