jsancio commented on code in PR #18852:
URL: https://github.com/apache/kafka/pull/18852#discussion_r1964116969
##########
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##########
@@ -1383,10 +1432,32 @@ class UnifiedLogTest {
// this is a bit contrived. to trigger the duplicate case for a follower
append, we have to append
// a batch with matching sequence numbers, but valid increasing offsets
assertEquals(0L, log.logEndOffset)
- log.appendAsFollower(MemoryRecords.withIdempotentRecords(0L,
Compression.NONE, pid, epoch, baseSequence,
- partitionLeaderEpoch, new SimpleRecord("a".getBytes), new
SimpleRecord("b".getBytes)))
- log.appendAsFollower(MemoryRecords.withIdempotentRecords(2L,
Compression.NONE, pid, epoch, baseSequence,
- partitionLeaderEpoch, new SimpleRecord("a".getBytes), new
SimpleRecord("b".getBytes)))
+ log.appendAsFollower(
+ MemoryRecords.withIdempotentRecords(
+ 0L,
+ Compression.NONE,
+ pid,
+ epoch,
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
