gharris1727 commented on code in PR #17743:
URL: https://github.com/apache/kafka/pull/17743#discussion_r1968471304
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##########
@@ -1788,19 +1817,19 @@ public WorkerTask<T, R> build() {
Objects.requireNonNull(classLoader, "Classloader used by task
cannot be null");
ErrorHandlingMetrics errorHandlingMetrics =
errorHandlingMetrics(id);
- final Class<? extends Connector> connectorClass =
plugins.connectorClass(
-
connectorConfig.getString(ConnectorConfig.CONNECTOR_CLASS_CONFIG));
+
+ final Connector connector =
instantiateConnector(connectorConfig.originalsStrings());
Review Comment:
We added a method for that which also avoid instantiating the plugin,
Plugins#pluginVersion. Minimizing instantiations is relatively important
because we don't know what sort of resources these plugins allocate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
