gharris1727 commented on code in PR #17743:
URL: https://github.com/apache/kafka/pull/17743#discussion_r1968481376
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java:
##########
@@ -549,7 +549,7 @@ public HeaderConverter newHeaderConverter(AbstractConfig
config, String classPro
}
private HeaderConverter newHeaderConverter(AbstractConfig config, String
classPropertyName, String versionPropertyName, ClassLoaderUsage
classLoaderUsage) {
- if (!config.originals().containsKey(classPropertyName) &&
classLoaderUsage == ClassLoaderUsage.CURRENT_CLASSLOADER) {
+ if (config.getClass(classPropertyName) == null && classLoaderUsage ==
ClassLoaderUsage.CURRENT_CLASSLOADER) {
Review Comment:
Just restating for myself:
The ConnectorConfig does not have a default, this change does not change the
flow.
The WorkerConfig used to set ClassLoaderUsage.PLUGINS which would skip this
condition.
Now the WorkerConfig can sometimes come with
ClassLoaderUsage.CURRENT_CLASSLOADER, and this condition needs to change to
still skip this condition. And the WorkerConfig has a default, so the condition
gets skipped.
SGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
