junrao commented on PR #18997: URL: https://github.com/apache/kafka/pull/18997#issuecomment-2679965954
> 3. CompleteActivationEvent should NOT use FeatureControlManager#metadataVersionOrThrow if the log is empty, since the FeatureControlManager has not yet set the MV. We could change `FeatureControlManager.metadataVersion` to return an option and use it in `CompleteActivationEvent`. With this, we could remove the `isEmpty` param in ActivationRecordsGenerator.generate() since it's the same as metadataVersion being empty. We could do 1-3 in a followup jira. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
