junrao commented on code in PR #18997:
URL: https://github.com/apache/kafka/pull/18997#discussion_r1968324927
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTestEnv.java:
##########
@@ -135,10 +135,6 @@ private QuorumControllerTestEnv(
}
QuorumController activeController() throws InterruptedException {
- return activeController(false);
- }
-
- QuorumController activeController(boolean waitForActivation) throws
InterruptedException {
Review Comment:
`controlEnv.activeController()` is called multiple times in some of the
tests. It's a bit wasteful to have to append/wait for a new event in every
call. Perhaps we could cache the returned `QuorumController` and reuse it in
those tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
