cmccabe commented on code in PR #18949:
URL: https://github.com/apache/kafka/pull/18949#discussion_r1972230877


##########
core/src/main/scala/kafka/raft/RaftManager.scala:
##########
@@ -104,6 +104,8 @@ trait RaftManager[T] {
   def replicatedLog: ReplicatedLog
 
   def voterNode(id: Int, listener: ListenerName): Option[Node]
+
+  def getRecordSerde: RecordSerde[T]

Review Comment:
   In Kafka we generally don't put 'get' in front of getters. So this method 
should just be `recordSerde`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to