cmccabe commented on code in PR #18949:
URL: https://github.com/apache/kafka/pull/18949#discussion_r1980321524
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -194,6 +194,7 @@ class BrokerServer(
val clientMetricsReceiverPlugin = new ClientMetricsReceiverPlugin()
config.dynamicConfig.initialize(Some(clientMetricsReceiverPlugin))
+ DynamicBrokerConfig.readDynamicBrokerConfigsFromSnapshot(raftManager,
config, quotaManagers)
Review Comment:
> Could you illuminate some of these cases for me?
One use case is if we have changed the network configuration in such a way
that the old static configuration isn't valid. The SSL keystore file being
moved is a good example. In that case we would not want to start up with the
old static configuration
> If so, that means we can't use raftManager to actually perform the
snapshot read, right?
It shouldn't be necessary to use raftManager to read the snapshot, since the
snapshot is just a file. Maybe we could have some static utility method which
finds the last snapshot file (it's just a matter of finding the one that sorts
last in the folder...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
