ijuma commented on code in PR #18726:
URL: https://github.com/apache/kafka/pull/18726#discussion_r1972672957
##########
clients/src/main/resources/common/message/FetchResponse.json:
##########
@@ -106,7 +106,7 @@
]},
{ "name": "PreferredReadReplica", "type": "int32", "versions": "11+",
"default": "-1", "ignorable": false, "entityType": "brokerId",
"about": "The preferred read replica for the consumer to use on its
next fetch request."},
- { "name": "Records", "type": "records", "versions": "0+",
"nullableVersions": "0+", "about": "The record data."}
Review Comment:
@chia7712 The unsupported compression case is extremely rare because it
needs a client that does not support zstd and the topic to be configured with
zstd. Each is rare in isolation (compression is usually defined on the producer
and zstd has been supported by clients since 2.1) and the combination is even
more so.
For @junrao's question, @chia7712 are you saying that we actually don't end
up with null records in that case? I haven't checked it carefully yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
