junrao commented on code in PR #18726:
URL: https://github.com/apache/kafka/pull/18726#discussion_r1976209643
##########
clients/src/main/resources/common/message/FetchResponse.json:
##########
@@ -106,7 +106,7 @@
]},
{ "name": "PreferredReadReplica", "type": "int32", "versions": "11+",
"default": "-1", "ignorable": false, "entityType": "brokerId",
"about": "The preferred read replica for the consumer to use on its
next fetch request."},
- { "name": "Records", "type": "records", "versions": "0+",
"nullableVersions": "0+", "about": "The record data."}
Review Comment:
@ijuma :
> 1. I can remove non-nullable from the schema if people feel strongly.
That's my feeling since we don't want to set a precedence of changing a
schema without a KIP, unless there is a strong reason.
> 2. But I will still make sure the Kafka code never returns null for
records.
That's fine since it doesn't violate the original schema.
Post 4.0, if we want to enforce non-null at the schema level, we could do
that through a KIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
