chia7712 commented on code in PR #18926:
URL: https://github.com/apache/kafka/pull/18926#discussion_r1976941671
##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##########
@@ -359,7 +356,10 @@ public void
testInitializeAsResignedLeaderFromStateStore(boolean withKip853Rpc)
assertEquals(0L, context.log.endOffset().offset());
context.assertElectedLeader(epoch, localId);
context.client.poll();
- assertThrows(NotLeaderException.class, () ->
context.client.prepareAppend(epoch, Arrays.asList("a", "b")));
+ // Only one method invocation is expected when testing runtime
exceptions
Review Comment:
Thank you for sharing all of this. We prefer to keep this PR focused on
fixing only what's necessary. Other improvements can be addressed in a
follow-up if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
