leaf-soba commented on code in PR #18926:
URL: https://github.com/apache/kafka/pull/18926#discussion_r1976979280
##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##########
@@ -359,7 +356,10 @@ public void
testInitializeAsResignedLeaderFromStateStore(boolean withKip853Rpc)
assertEquals(0L, context.log.endOffset().offset());
context.assertElectedLeader(epoch, localId);
context.client.poll();
- assertThrows(NotLeaderException.class, () ->
context.client.prepareAppend(epoch, Arrays.asList("a", "b")));
+ // Only one method invocation is expected when testing runtime
exceptions
Review Comment:
@chia7712 Thank you for your feedback! I have reverted the unnecessary
change related to throwing two exceptions in one assertThrows.
There are still some other minor improvements—would you prefer that I revert
all of them in this PR, or should I keep them and address them in a follow-up
PR instead? I'm happy to proceed in whichever way aligns best with the
project's approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
