soondenana commented on code in PR #19163:
URL: https://github.com/apache/kafka/pull/19163#discussion_r1985891433
##########
clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java:
##########
@@ -122,8 +124,8 @@ public final ByteBuffer serializeWithHeader(RequestHeader
header) {
}
// Visible for testing
- public final ByteBuffer serialize() {
- return MessageUtil.toByteBuffer(data(), version);
+ public final Readable serialize() {
Review Comment:
> Maybe just return `ByteAccessor`?
Added an overloaded method for test cases where they need ByteBuffer to
validate properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
