cadonna commented on code in PR #19230:
URL: https://github.com/apache/kafka/pull/19230#discussion_r2010066289
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java:
##########
@@ -59,6 +62,10 @@
*/
public class StreamsGroupHeartbeatRequestManager implements RequestManager {
+ private static final String UNSUPPORTED_VERSION_ERROR_MESSAGE = "The
cluster does not support the new STREAMS group protocol. Set " +
Review Comment:
Yes, if in a remote future the earliest versions of the Streams heartbeat
RPC are removed, the broker would also respond with an `UNSUPPORTED_VERSION`
error (see
[KIP-896](https://cwiki.apache.org/confluence/display/KAFKA/KIP-896%3A+Remove+old+client+protocol+API+versions+in+Kafka+4.0)).
I wondering what we should put into the error message. Referring also to the
possibility that the broker does not support the version of the RPC anymore,
seems confusing to me. What about a simple:
"The cluster does not support the STREAMS group protocol or does not support
the versions of the STREAMS group protocol used by this client (supported
versions: <lowest_supported_version> to <highest_supported_version>)".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
