lucasbru commented on code in PR #19230:
URL: https://github.com/apache/kafka/pull/19230#discussion_r2009923439
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java:
##########
@@ -451,6 +462,143 @@ private void onSuccessResponse(final
StreamsGroupHeartbeatResponse response, fin
membershipManager.onHeartbeatSuccess(response);
}
+ private void onErrorResponse(final StreamsGroupHeartbeatResponse response,
final long currentTimeMs) {
Review Comment:
These seem to be only the errors that can happen in the consumer protocol.
What about
```
* - {@link Errors#STREAMS_INVALID_TOPOLOGY}
* - {@link Errors#STREAMS_INVALID_TOPOLOGY_EPOCH}
* - {@link Errors#STREAMS_TOPOLOGY_FENCED}
```
?
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java:
##########
@@ -59,6 +62,10 @@
*/
public class StreamsGroupHeartbeatRequestManager implements RequestManager {
+ private static final String UNSUPPORTED_VERSION_ERROR_MESSAGE = "The
cluster does not support the new STREAMS group protocol. Set " +
Review Comment:
Could it also be that the broker supports the streams protocol, but it's not
enabled? Could it also be that the broker is so new that it doesn't support the
RPC version anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
