[ https://issues.apache.org/jira/browse/KAFKA-7917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765551#comment-16765551 ]
Lee Dongjin commented on KAFKA-7917: ------------------------------------ [~vvcephei] Thanks for creating the issue. I also have been thinking about this issue. Here are some suggestions: 1. How about making an umbrella issue like 'Improve Streams Store implementations' and make related issues (KAFKA-7916, KAFKA-7917, KAFKA-7918, KAFKA-7919) the subtasks of it? 2. Also, these issues need a discussion as [~mjsax] commented. How about opening a discussion thread after packing them under the umbrella issue? > Streams store cleanup: collapse layers > -------------------------------------- > > Key: KAFKA-7917 > URL: https://issues.apache.org/jira/browse/KAFKA-7917 > Project: Kafka > Issue Type: Improvement > Components: streams > Reporter: John Roesler > Priority: Major > > Following on KAFKA-7916, we can consider collapsing the "streams management > layers" into one. > Right now, we have: > * metering (also handles moving from pojo world to bytes world) > * change-logging > * caching > This is good compositional style, but we also have some runtime overhead of > calling through all these layers, as well as some mental overhead of > understanding how many and which layers we are going through. > Also, there are dependencies between the caching and change-logging layers. > I _think_ it would simplify the code if we collapsed these into one layer > with boolean switches to turn on or off the different aspects. (rather than > wrapping the store with the different layers or not depending on the same > boolean conditions) -- This message was sent by Atlassian JIRA (v7.6.3#76005)