[
https://issues.apache.org/jira/browse/KAFKA-7917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767574#comment-16767574
]
John Roesler commented on KAFKA-7917:
-------------------------------------
After messing with the code for a while, I'm not happy with the trade-offs.
Some parts combine cleanly, but others are tightly coupled with different
components of Streams, and smashing them all together creates more of a mess.
I'm going to close this ticket, and we'll just take this one step at a time by
seeing how the codebase looks afterÂ
https://issues.apache.org/jira/browse/KAFKA-7918
> Streams store cleanup: collapse layers
> --------------------------------------
>
> Key: KAFKA-7917
> URL: https://issues.apache.org/jira/browse/KAFKA-7917
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: John Roesler
> Assignee: John Roesler
> Priority: Major
>
> Following on KAFKA-7916, we can consider collapsing the "streams management
> layers" into one.
> Right now, we have:
> * metering (also handles moving from pojo world to bytes world)
> * change-logging
> * caching
> This is good compositional style, but we also have some runtime overhead of
> calling through all these layers, as well as some mental overhead of
> understanding how many and which layers we are going through.
> Also, there are dependencies between the caching and change-logging layers.
> I _think_ it would simplify the code if we collapsed these into one layer
> with boolean switches to turn on or off the different aspects. (rather than
> wrapping the store with the different layers or not depending on the same
> boolean conditions)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
