TaiJuWu commented on code in PR #19947:
URL: https://github.com/apache/kafka/pull/19947#discussion_r2139266780
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -114,6 +114,8 @@ class ReplicaManagerTest {
private val topicId = Uuid.fromString("YK2ed2GaTH2JpgzUaJ8tgg")
private val topicIds = scala.Predef.Map("test-topic" -> topicId)
private val topicNames = topicIds.map(_.swap)
+ private val topicPartition0 = new TopicPartition(topic, 0)
+ private val topicPartition1 = new TopicPartition(topic, 1)
Review Comment:
After kafka 4.0 version, we support topic Id for KRAFT mode.
Should we also add `topicIdPartion0` and `topicIdPartion1` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
