jingjia88 commented on code in PR #19947: URL: https://github.com/apache/kafka/pull/19947#discussion_r2140329843
########## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ########## @@ -4302,7 +4239,6 @@ class ReplicaManagerTest { val replicaManager = setupReplicaManagerWithMockedPurgatories(new MockTimer(time)) try { val brokerList = Seq[Integer](0, 1).asJava - val topicPartition = new TopicPartition(topic, 0) val topicIds = Collections.singletonMap(topic, Uuid.randomUuid()) val topicNames = topicIds.asScala.map(_.swap).asJava Review Comment: Thanks for the suggestion! Since this PR focuses on updating testPartitionMetadataFile as suggested by chia-ping, maybe we can refactor them in a follow-up if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org