mjsax commented on code in PR #17022:
URL: https://github.com/apache/kafka/pull/17022#discussion_r2141308186
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -779,14 +779,25 @@ public synchronized void
maybeTransitionToErrorState(RuntimeException exception)
}
synchronized void handleFailedBatch(ProducerBatch batch, RuntimeException
exception, boolean adjustSequenceNumbers) {
- maybeTransitionToErrorState(exception);
+ // Compare the batch with the current ProducerIdAndEpoch. If the
producer IDs are the *same* but the epochs
+ // are *different*, consider the batch as stale.
+ boolean isStaleBatch = batch.producerId() ==
producerIdAndEpoch.producerId && batch.producerEpoch() !=
producerIdAndEpoch.epoch;
Review Comment:
Is `batch.producerEpoch() != producerIdAndEpoch.epoch` ok? Or should it be
`batch.producerEpoch() < producerIdAndEpoch.epoch`?
On the other hand, we don't have a check here for batch.producerEpoch() >
producerIdAndEpoch.epoch` which should never happen? Should we add such a check
(or does it maybe exist somewhere else)? Or do we not care?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
