Rancho-7 commented on code in PR #19966:
URL: https://github.com/apache/kafka/pull/19966#discussion_r2148347055
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -970,29 +964,19 @@ class ReplicaManagerTest {
@Test
def testFetchBeyondHighWatermark(): Unit = {
+ val localId = 0
val rm = setupReplicaManagerWithMockedPurgatories(new MockTimer(time),
aliveBrokerIds = Seq(0, 1, 2))
try {
- val brokerList = Seq[Integer](0, 1, 2).asJava
val partition = rm.createPartition(new TopicPartition(topic, 0))
partition.createLogIfNotExists(isNew = false, isFutureReplica = false,
new LazyOffsetCheckpoints(rm.highWatermarkCheckpoints.asJava), None)
// Make this replica the leader.
- val leaderAndIsrRequest1 = new LeaderAndIsrRequest.Builder(0, 0,
brokerEpoch,
- Seq(new LeaderAndIsrRequest.PartitionState()
- .setTopicName(topic)
- .setPartitionIndex(0)
- .setControllerEpoch(0)
- .setLeader(0)
- .setLeaderEpoch(0)
- .setIsr(brokerList)
- .setPartitionEpoch(0)
- .setReplicas(brokerList)
- .setIsNew(false)).asJava,
- topicIds.asJava,
- Set(new Node(0, "host1", 0), new Node(1, "host2", 1), new Node(2,
"host2", 2)).asJava).build()
- rm.becomeLeaderOrFollower(0, leaderAndIsrRequest1, (_, _) => ())
+ val leaderDelta = topicsCreateDelta(localId, isStartIdLeader = true,
topicName = topic, topicId = topicIds(topic))
Review Comment:
Thanks for catching this! Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
