Rancho-7 commented on code in PR #19966:
URL: https://github.com/apache/kafka/pull/19966#discussion_r2148956168
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -979,20 +973,20 @@ class ReplicaManagerTest {
new LazyOffsetCheckpoints(rm.highWatermarkCheckpoints.asJava), None)
// Make this replica the leader.
- val leaderAndIsrRequest1 = new LeaderAndIsrRequest.Builder(0, 0,
brokerEpoch,
- Seq(new LeaderAndIsrRequest.PartitionState()
- .setTopicName(topic)
- .setPartitionIndex(0)
- .setControllerEpoch(0)
- .setLeader(0)
- .setLeaderEpoch(0)
- .setIsr(brokerList)
- .setPartitionEpoch(0)
- .setReplicas(brokerList)
- .setIsNew(false)).asJava,
- topicIds.asJava,
- Set(new Node(0, "host1", 0), new Node(1, "host2", 1), new Node(2,
"host2", 2)).asJava).build()
- rm.becomeLeaderOrFollower(0, leaderAndIsrRequest1, (_, _) => ())
+ val leaderDelta = new TopicsDelta(TopicsImage.EMPTY)
+ leaderDelta.replay(new TopicRecord().setName(topic).setTopicId(topicId))
+ leaderDelta.replay(new PartitionRecord()
+ .setPartitionId(0)
+ .setTopicId(topicId)
+ .setReplicas(brokerList)
+ .setIsr(brokerList)
+ .setRemovingReplicas(Collections.emptyList())
Review Comment:
removed them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
