ocadaruma commented on code in PR #19972:
URL: https://github.com/apache/kafka/pull/19972#discussion_r2160480289
##########
storage/src/test/java/org/apache/kafka/storage/internals/log/LogSegmentTest.java:
##########
@@ -856,6 +865,48 @@ public void
testNonMonotonicTimestampForMultipleBatchesInMemoryRecords() throws
assertEquals(new TimestampOffset(2, 2), segment.timeIndex().entry(1));
}
+ @Test
+ @Timeout(30)
+ public void testConcurrentAccessToMaxTimestampSoFar() throws Exception {
+ int numThreads = 16;
+ ExecutorService executor = Executors.newFixedThreadPool(numThreads);
+ TimeIndex mockTimeIndex = mock(TimeIndex.class);
+ when(mockTimeIndex.lastEntry()).thenReturn(new
TimestampOffset(RecordBatch.NO_TIMESTAMP, 0L));
+
+ try {
+ // to reproduce race, we iterate test for certain duration
+ long remainingDurationNanos = Duration.ofSeconds(1).toNanos();
+ while (remainingDurationNanos > 0) {
+ long t0 = System.nanoTime();
+ clearInvocations(mockTimeIndex);
+ try (LogSegment seg = spy(LogTestUtils.createSegment(0,
logDir, 10, Time.SYSTEM))) {
+ when(seg.timeIndex()).thenReturn(mockTimeIndex);
+ List<Future<?>> futures = new ArrayList<>();
+ for (int i = 0; i < numThreads; i++) {
+ futures.add(executor.submit(() -> {
Review Comment:
thanks, fixed to use assertDoesNotThrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
