chia7712 commented on code in PR #19972:
URL: https://github.com/apache/kafka/pull/19972#discussion_r2161149343
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java:
##########
@@ -192,8 +195,13 @@ public void sanityCheck(boolean timeIndexFileNewlyCreated)
throws IOException {
* the time index).
*/
public TimestampOffset readMaxTimestampAndOffsetSoFar() throws IOException
{
- if (maxTimestampAndOffsetSoFar == TimestampOffset.UNKNOWN)
- maxTimestampAndOffsetSoFar = timeIndex().lastEntry();
+ if (maxTimestampAndOffsetSoFar == TimestampOffset.UNKNOWN) {
+ synchronized (maxTimestampAndOffsetLock) {
Review Comment:
Could you please add comments for this lock? By default, `LogSegment` is not
thread-safe so all modification should be executed within `UnifiedLog` lock.
However, there is an exceptional path that could change the
`maxTimestampAndOffsetSoFar` without `UnifiedLog` lock, which causes this
concurrent issue ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
