chia7712 commented on code in PR #19869:
URL: https://github.com/apache/kafka/pull/19869#discussion_r2162016698
##########
connect/api/src/main/java/org/apache/kafka/connect/data/SchemaBuilder.java:
##########
@@ -185,7 +184,7 @@ public SchemaBuilder doc(String doc) {
@Override
public Map<String, String> parameters() {
- return parameters == null ? null :
Collections.unmodifiableMap(parameters);
+ return parameters == null ? null : Map.copyOf(parameters);
Review Comment:
According to comment in line#198, the order is kept as expected. Perhaps, we
should keep using `Collections.unmodifiableMap`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
