chia7712 commented on code in PR #19869:
URL: https://github.com/apache/kafka/pull/19869#discussion_r2180024253
##########
connect/api/src/main/java/org/apache/kafka/connect/data/Values.java:
##########
@@ -1273,10 +1254,8 @@ public boolean canDetect(Object value) {
}
if (knownType == null) {
knownType = schema.type();
- } else if (knownType != schema.type()) {
Review Comment:
```java
if (knownType == null) knownType = schema.type();
return knownType == schema.type();
```
How about using this style?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
