cmccabe commented on code in PR #19745:
URL: https://github.com/apache/kafka/pull/19745#discussion_r2164629367
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -411,7 +411,7 @@ class BrokerServer(
config,
"heartbeat",
s"broker-${config.nodeId}-",
- config.brokerSessionTimeoutMs / 2 // KAFKA-14392
+ config.brokerHeartbeatIntervalMs
Review Comment:
> Can you file a Jira for both of these?
Filed KAFKA-19432: Add an ERROR log message if broker.heartbeat.interval.ms
is too large
Filed KAFKA-19433: Unify broker heartbeat RPC timeout and periodic resend
timeout
> Is it better for the user to have previously valid config now be invalid?
Or have a cluster that causes brokers to fence incorrectly?
If we want a compatibility break, we'd need a KIP. I think it's unlikely to
be worth the effort here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
