cmccabe commented on code in PR #19745:
URL: https://github.com/apache/kafka/pull/19745#discussion_r2164632407
##########
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##########
@@ -577,10 +563,9 @@ class BrokerLifecycleManager(
}
private def scheduleNextCommunicationAfterFailure(): Unit = {
- val delayMs = resendExponentialBackoff.backoff(failedAttempts)
- failedAttempts = failedAttempts + 1
nextSchedulingShouldBeImmediate = false // never immediately reschedule
after a failure
- scheduleNextCommunication(NANOSECONDS.convert(delayMs, MILLISECONDS))
Review Comment:
The failure scenario is that if the exponential backoff is at its maximum
value, and the RPC hangs for its maximum time, we don't resent until the broker
session timeout has already expired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
