appchemist commented on code in PR #18800:
URL: https://github.com/apache/kafka/pull/18800#discussion_r2173637192
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##########
@@ -614,6 +614,14 @@ private GraphNode getKeyChangingParentNode(final GraphNode
repartitionNode) {
return null;
}
+ protected boolean isRepartitionRequired(final GraphNode node) {
Review Comment:
I agree.
I overlooked it while focusing on reusing the
`InternalStreamsBuilder.findParentNodeMatching`.
I also moved `InternalStreamsBuilder.findParentNodeMatching` to GraphNode,
as it seemed more appropriate there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
