appchemist commented on code in PR #18800: URL: https://github.com/apache/kafka/pull/18800#discussion_r2173644002
########## streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/GraphNode.java: ########## @@ -27,12 +27,17 @@ import java.util.Optional; public abstract class GraphNode { - + private enum Repartition { + NOT_REQUIRED, + BY_KEY_ONLY, + ALWAYS_REQUIRED, Review Comment: [As mentioned above](https://github.com/apache/kafka/pull/18800#discussion_r2173641799), we can’t use `processNode.setKeyChangingOperation(true)`, but there was one case where repartitioning was still required. I’m still unsure about the naming of the `Repartition` enum. For now, I’ve renamed `ALWAYS_REQUIRED` to `REQUIRED`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org