OmniaGM commented on code in PR #19964:
URL: https://github.com/apache/kafka/pull/19964#discussion_r2178049890
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##########
@@ -892,7 +901,7 @@ private void sendProduceRequest(long now, int destination,
short acks, int timeo
.setTopicData(tpd),
useTransactionV1Version
);
- RequestCompletionHandler callback = response ->
handleProduceResponse(response, recordsByPartition, time.milliseconds());
+ RequestCompletionHandler callback = response ->
handleProduceResponse(response, recordsByPartition, metadata.topicNames(),
time.milliseconds());
Review Comment:
Updated this, if this still not working and the 1st patch is better am
thinking of going back to something similiar to first one and maybe have a flag
in TopicIdPartition for `ignoreTopicName` that make `equals` and `hashcode`
works when topic name not there so when we do `get` on `batches
<TopicIdPartitions, ProducerBatch>` would get the expected batch without extra
iteration that was originally proposed in first commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
