junrao commented on code in PR #19964:
URL: https://github.com/apache/kafka/pull/19964#discussion_r2178056683
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##########
@@ -609,7 +606,20 @@ private void handleProduceResponse(ClientResponse
response, Map<TopicPartition,
.collect(Collectors.toList()),
p.errorMessage(),
p.currentLeader());
+
+ // Version 13 drop topic name and add support to topic id.
+ // We need to find batch based on topic id and partition
index only as
+ // topic name in the response will be empty.
+ // For older versions, topic id is zero, and we will find
the batch based on the topic name.
+ TopicPartition tp = (!r.topicId().equals(Uuid.ZERO_UUID)
&& topicNames.containsKey(r.topicId())) ?
+ new TopicPartition(topicNames.get(r.topicId()),
p.index()) :
+ new TopicPartition(r.name(), p.index());
+
ProducerBatch batch = batches.get(tp);
+ if (batch == null) {
+ throw new IllegalStateException("Can't find batch
created for topic id " + r.topicId() +
+ " topic name " + r.name() + "-" + p.index() +
" using " + topicNames);
Review Comment:
"-" + p.index() => " partition " + p.index() ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
