m1a2st commented on code in PR #20087:
URL: https://github.com/apache/kafka/pull/20087#discussion_r2180291763
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LoadedLogOffsets.java:
##########
@@ -18,11 +18,7 @@
import java.util.Objects;
-public class LoadedLogOffsets {
- public final long logStartOffset;
- public final long recoveryPoint;
- public final LogOffsetMetadata nextOffsetMetadata;
-
+public record LoadedLogOffsets(long logStartOffset, long recoveryPoint,
LogOffsetMetadata nextOffsetMetadata) {
public LoadedLogOffsets(final long logStartOffset,
final long recoveryPoint,
final LogOffsetMetadata nextOffsetMetadata) {
Review Comment:
Should we remain `equals()`, `hashCode()`, `toString()` for this record?
##########
storage/src/test/java/org/apache/kafka/storage/internals/log/LogValidatorTest.java:
##########
@@ -545,12 +545,12 @@ public void checkCompressed(byte magic) {
RequestLocal.withThreadConfinedCaching().bufferSupplier()
);
- MemoryRecords validatedRecords = validatedResults.validatedRecords;
+ MemoryRecords validatedRecords = validatedResults.validatedRecords();
int i = 0;
for (RecordBatch batch : validatedRecords.batches()) {
assertTrue(batch.isValid());
- assertEquals(batch.timestampType(), TimestampType.CREATE_TIME);
+ assertEquals(TimestampType.CREATE_TIME, batch.timestampType());
maybeCheckBaseTimestamp(timestampSeq.get(0), batch);
assertEquals(batch.maxTimestamp(), batch.maxTimestamp());
Review Comment:
This assertion also can remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
