mimaison commented on code in PR #20087: URL: https://github.com/apache/kafka/pull/20087#discussion_r2191823753
########## storage/src/main/java/org/apache/kafka/storage/internals/log/BatchMetadata.java: ########## @@ -44,28 +28,6 @@ public long firstOffset() { return lastOffset - offsetDelta; } - @Override - public boolean equals(Object o) { - if (this == o) return true; - if (o == null || getClass() != o.getClass()) return false; - - BatchMetadata that = (BatchMetadata) o; - - return lastSeq == that.lastSeq && - lastOffset == that.lastOffset && - offsetDelta == that.offsetDelta && - timestamp == that.timestamp; - } - - @Override - public int hashCode() { - int result = lastSeq; - result = 31 * result + Long.hashCode(lastOffset); - result = 31 * result + offsetDelta; - result = 31 * result + Long.hashCode(timestamp); - return result; - } - @Override public String toString() { Review Comment: Not here as this also prints `firstSeq` and `firstOffset` which are not fields. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org