showuon commented on code in PR #20045:
URL: https://github.com/apache/kafka/pull/20045#discussion_r2184545082
##########
core/src/test/scala/integration/kafka/server/DelayedRemoteFetchTest.scala:
##########
@@ -235,7 +471,8 @@ class DelayedRemoteFetchTest {
highWatermark: Int = 0,
leaderLogStartOffset: Int = 0): LogReadResult = {
new LogReadResult(
- new FetchDataInfo(LogOffsetMetadata.UNKNOWN_OFFSET_METADATA,
MemoryRecords.EMPTY),
+ new FetchDataInfo(LogOffsetMetadata.UNKNOWN_OFFSET_METADATA,
MemoryRecords.EMPTY, false, Optional.empty(),
+ Optional.of(mock(classOf[RemoteStorageFetchInfo]))),
Review Comment:
You're right! We did not test what we expected to be tested. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
