showuon commented on PR #20045: URL: https://github.com/apache/kafka/pull/20045#issuecomment-3034733623
> 1. The FETCH request now has to wait to get response from all the remote partitions. And, it can have tail-latency. This tradeoff is fine considering the consumer might have to read the same data in the upcoming FETCH requests. This can be documented in the PR. Good point. I've updated the doc in `remote.fetch.max.wait` to mention the waiting all fetch behavior, and reverted the change in this [PR](https://github.com/apache/kafka/pull/19336) about the limitation. > 2. When minOneMessage set to false (from second partition in the request), and there are multiple remote reads in the given FETCH request. We may read the data from remote and then drop those when the size of the message does not fit the partition limit. This was fine for local-reads but remote-reads might fetch chunk of data and multiple responses might be dropped. Shall we add some DEBUG logs when the remote fetched data gets dropped? I agree with you. Added a debug log. Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
