lbradstreet commented on code in PR #20061:
URL: https://github.com/apache/kafka/pull/20061#discussion_r2188817416
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -1921,14 +1921,14 @@ private
CompletableFuture<DeleteShareGroupOffsetsResponseData> handleDeleteShare
errorTopicResponses.add(
new
DeleteShareGroupOffsetsResponseData.DeleteShareGroupOffsetsResponseTopic()
.setTopicId(topicData.topicId())
-
.setTopicName(metadataImage.topics().topicIdToNameView().get(topicData.topicId()))
+
.setTopicName(metadataImage.topicName(topicData.topicId()).orElse("<UNKNOWN>"))
Review Comment:
Hmm, I was going to say that an error code should be set, but this is the
error case anyway. I guess if the current behavior is to return null then I
guess we should still return null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
