zzbennett commented on code in PR #20061: URL: https://github.com/apache/kafka/pull/20061#discussion_r2191440905
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ########## @@ -8117,7 +8112,7 @@ public List<DeleteShareGroupStateRequestData.DeleteStateData> sharePartitionsEli // If the topic for which delete share group offsets request is sent is already present in the deletingTopics set, // we will include that topic in the delete share group state request. List<DeleteShareGroupStateRequestData.PartitionData> partitions = new ArrayList<>(); - topicImage.partitions().keySet().forEach(partition -> + IntStream.range(0, topicMetadata.partitionCount()).boxed().collect(Collectors.toSet()).forEach(partition -> Review Comment: ah good catch, yea that was some copy pasta from removing the built-in `partitions()` method from the CoordinatorMetadata interface -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org