gaurav-narula commented on PR #20105: URL: https://github.com/apache/kafka/pull/20105#issuecomment-3048134092
Thanks for the PR! From the discussion in the previous PRs (https://github.com/apache/kafka/pull/9910#discussion_r560599641 and https://github.com/apache/kafka/pull/13949#issuecomment-1618518677), one of the reasons to limit the change to frequently instantiated classes was an understanding that the `Logging` trait isn't a good-pattern. Given there's a lot of refactoring in progress specially around the Scala code, should we instead look at moving away from the `Logging` trait? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
