terrytlu commented on PR #20105: URL: https://github.com/apache/kafka/pull/20105#issuecomment-3048684944
> Thanks for the PR! From the discussion in the previous PRs ([#9910 (comment)](https://github.com/apache/kafka/pull/9910#discussion_r560599641) and [#13949 (comment)](https://github.com/apache/kafka/pull/13949#issuecomment-1618518677)), one of the reasons to limit the change to frequently instantiated classes was an understanding that the `Logging` trait isn't a good-pattern. > > Given there's a lot of refactoring in progress specially around the Scala code, should we instead look at moving away from the `Logging` trait? Moving away from the Logging trait would require lots of work to refactor, every class that needs to log would need to create an object containing the logger. Not an easy proposal to implement I think... @gaurav-narula -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
