apoorvmittal10 commented on code in PR #20144:
URL: https://github.com/apache/kafka/pull/20144#discussion_r2198617405
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -717,7 +718,7 @@ private Optional<Builder<?>>
createPushRequest(ClientTelemetrySubscription local
ByteBuffer compressedPayload;
try {
compressedPayload = ClientTelemetryUtils.compress(payload,
compressionType);
- } catch (Throwable e) {
+ } catch (IOException | NoClassDefFoundError e) {
log.debug("Failed to compress telemetry payload for
compression: {}, sending uncompressed data", compressionType);
Review Comment:
What about the compressionType in the next call i.e. once this error is
encountered then it will happen for every push hence do we want to try other
compression types as supported by broker or move to compression type `none` for
next push?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
